Skip to content

Fix nvda find title cancellation #11632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 13 commits into from
Oct 8, 2020
Merged

Fix nvda find title cancellation #11632

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0c01090
Don't cancel speech for focused windows
feerrenrut Sep 17, 2020
224dee1
Use dialog instead of Window
feerrenrut Sep 18, 2020
d3b26dc
Add devInfo logging for new check
feerrenrut Sep 18, 2020
ace2e4a
WIP use api.getForegroundObject
feerrenrut Sep 24, 2020
d2dcb6c
WIP investigate why focus ancestry is not accurate.
feerrenrut Sep 24, 2020
b48eaa8
address timing mismatch for current focus object and focus ancestors
feerrenrut Oct 1, 2020
aada2f1
Readability of focus lost cancelled speech
feerrenrut Oct 1, 2020
efe98ce
remove temp debug logging
feerrenrut Oct 2, 2020
bf697a7
More details for docstring
feerrenrut Oct 2, 2020
8782e40
Fix indentation level
feerrenrut Oct 2, 2020
ce46082
Merge remote-tracking branch 'origin/master' into fixNVDAFind-TitleCa…
feerrenrut Oct 2, 2020
9db07e2
Merge remote-tracking branch 'origin/master' into fixNVDAFind-TitleCa…
feerrenrut Oct 8, 2020
f7b0454
[skip ci] Update changes file for PR #11632
feerrenrut Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't cancel speech for focused windows
  • Loading branch information
@feerrenrut
feerrenrut committed Sep 18, 2020
commit 0c010900c0bc424b717e2259f1b629f61905f3f6
2 changes: 2 additions & 0 deletions source/eventHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def _getFocusLossCancellableSpeechCommand(
) -> Optional[_CancellableSpeechCommand]:
if reason != controlTypes.REASON_FOCUS or not speech.manager._shouldCancelExpiredFocusEvents():
return None
from NVDAObjects.window import Window
from NVDAObjects import NVDAObject
if not isinstance(obj, NVDAObject):
log.warning("Unhandled object type. Expected all objects to be descendant from NVDAObject")
Expand All @@ -181,6 +182,7 @@ def isSpeechStillValid():
isLastFocusObj()
or not previouslyHadFocus()
or isAncestorOfCurrentFocus()
or isinstance(obj, Window) # ensure new windows are reported
)
return stillValid

Expand Down