Skip to content

NVDA logging: add originating thread to log entry #10259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 5 commits into from
Sep 23, 2019
Merged

NVDA logging: add originating thread to log entry #10259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79ca608
Log thread info
LeonarddeR Sep 20, 2019
ef1ca5a
Name all threads in core
LeonarddeR Sep 21, 2019
6874cc7
Fix accidental change of scons submodule
LeonarddeR Sep 21, 2019
390b7b6
Small fixes
LeonarddeR Sep 21, 2019
279618c
Thread name logging: Generalize logging of full qualified names (#102…
JulienCochuyt Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small fixes
  • Loading branch information
@LeonarddeR
LeonarddeR committed Sep 21, 2019
commit 390b7b6187268cb8e606f36f95ac2c46134d13b4
2 changes: 1 addition & 1 deletion source/NVDAObjects/behaviors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def startMonitoring(self):
if self._monitorThread:
return
thread = self._monitorThread = threading.Thread(
name=f"{self.__class__.__name__}Monitor",
name=f"{self.__class__.__qualname__}._monitorThread",
>
)
thread.daemon = True
Expand Down
13 changes: 1 addition & 12 deletions source/logHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,7 @@ class Logger(logging.Logger):
DEBUGWARNING = 15
OFF = 100

def _log(
self,
level,
msg,
args,
exc_info=None,
extra=None,
codepath=None,
thread=None,
activateLogViewer=False,
stack_info=None
):
def _log(self, level, msg, args, exc_info=None, extra=None, codepath=None, activateLogViewer=False, stack_info=None):
if not extra:
extra={}

Expand Down