Allow config profile triggers when Add-on Store is open - #19583
Merged
seanbudd merged 1 commit intoFeb 13, 2026
Merged
Conversation
The Add-on Store dialog inherited shouldSuspendConfigProfileTriggers = True from SettingsDialog, which prevented configuration profile triggers from activating while the dialog was open. Override this to False since the Add-on Store does not need to suspend config profile triggers.
bramd
force-pushed
the
fix/addon-store-config-profiles-15165
branch
from
February 9, 2026 16:09
db9eecd to
cf10890
Compare
SaschaCowley
added
the
conceptApproved
seanbudd
approved these changes
Feb 13, 2026
seanbudd
enabled auto-merge (squash)
February 13, 2026 04:27
seanbudd
disabled auto-merge
February 13, 2026 05:48
tareh7z
pushed a commit
to tareh7z/nvda
that referenced
this pull request
Feb 16, 2026
Closes nvaccess#15165 Summary of the issue: Configuration profile triggers for "Current application" do not activate when the Add-on Store dialog is open, even though the Add-on Store is an NVDA window. This is because AddonStoreDialog inherits from SettingsDialog, which has shouldSuspendConfigProfileTriggers = True to prevent feedback loops while editing settings. Description of user facing changes: Configuration profile triggers now activate when the Add-on Store is open. Users who create a config profile triggered by the NVDA application (e.g., to enable table headers in the Add-on Store) will now have their profile correctly activated. Description of developer facing changes: Added shouldSuspendConfigProfileTriggers = False to AddonStoreDialog to override the inherited value from SettingsDialog. Description of development approach: The SettingsDialog base class sets shouldSuspendConfigProfileTriggers = True because changing settings while a profile trigger is active could cause confusion. However, the Add-on Store doesn't modify NVDA settings, so there's no reason to suspend triggers. The fix simply overrides this attribute to False.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15165
Summary of the issue:
Configuration profile triggers for "Current application" do not activate when the Add-on Store dialog is open, even though the Add-on Store is an NVDA window. This is because
AddonStoreDialoginherits fromSettingsDialog, which hasshouldSuspendConfigProfileTriggers = Trueto prevent feedback loops while editing settings.Description of user facing changes:
Configuration profile triggers now activate when the Add-on Store is open. Users who create a config profile triggered by the NVDA application (e.g., to enable table headers in the Add-on Store) will now have their profile correctly activated.
Description of developer facing changes:
Added
shouldSuspendConfigProfileTriggers = FalsetoAddonStoreDialogto override the inherited value fromSettingsDialog.Description of development approach:
The
SettingsDialogbase class setsshouldSuspendConfigProfileTriggers = Truebecause changing settings while a profile trigger is active could cause confusion. However, the Add-on Store doesn't modify NVDA settings, so there's no reason to suspend triggers. The fix simply overrides this attribute toFalse.Testing strategy:
Known issues with pull request:
None
Code Review Checklist: