Skip to content

Commit d44f7a1

Browse files
bramdbramd
authored
Allow config profile triggers when Add-on Store is open (#19583)
Closes #15165 Summary of the issue: Configuration profile triggers for "Current application" do not activate when the Add-on Store dialog is open, even though the Add-on Store is an NVDA window. This is because AddonStoreDialog inherits from SettingsDialog, which has shouldSuspendConfigProfileTriggers = True to prevent feedback loops while editing settings. Description of user facing changes: Configuration profile triggers now activate when the Add-on Store is open. Users who create a config profile triggered by the NVDA application (e.g., to enable table headers in the Add-on Store) will now have their profile correctly activated. Description of developer facing changes: Added shouldSuspendConfigProfileTriggers = False to AddonStoreDialog to override the inherited value from SettingsDialog. Description of development approach: The SettingsDialog base class sets shouldSuspendConfigProfileTriggers = True because changing settings while a profile trigger is active could cause confusion. However, the Add-on Store doesn't modify NVDA settings, so there's no reason to suspend triggers. The fix simply overrides this attribute to False.
1 parent d0be47c commit d44f7a1

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

‎source/gui/addonStoreGui/controls/storeDialog.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ class AddonStoreDialog(SettingsDialog):
4141
# more adapted like "AddonStore" so that old external links pointing to the add-ons manager paragraph now
4242
# point to the Add-on Store one.
4343
helpId = "AddonsManager"
44+
shouldSuspendConfigProfileTriggers = False
4445

4546
def __init__(self, parent: wx.Window, storeVM: AddonStoreVM, openToTab: _StatusFilterKey | None = None):
4647
self._storeVM = storeVM

‎user_docs/en/changes.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ Consult the speech dictionaries section in the User Guide for more details. (#19
3131
* In Microsoft Word with UIA enabled, page changes are now correctly announced when navigating table rows that span multiple pages. (#19386, @akj)
3232
* Fixed excessive resource usage and highlight flickering when using Visual Highlight. (#17434, @hwf1324)
3333
* The `NVDA+k` command now correctly reports the destination of links containing formatted text, such as bold or italics. (#19428, @Cary-rowen)
34+
* Configuration profile triggers now activate when the Add-on Store is open. (#19583, @bramd)
3435

3536
### Changes for Developers
3637

0 commit comments

Comments
 (0)