Skip to content

MAINT: Do not let _GenericAlias wrap the underlying classes' __class__ attribute - #21982

Merged
mattip merged 1 commit into
numpy:mainfrom
BvB93:alias
Jul 14, 2022
Merged

mattip merged 1 commit into
numpy:mainfrom
BvB93:alias

Conversation

@BvB93

@BvB93 BvB93 commented Jul 14, 2022

Copy link
Copy Markdown
Member

Adapt to the 3.11b4 changes introduced in python/cpython#93754.

…s__` attribute

Adapt to the 3.11b4 changes introduced in python/cpython#93754

@mattip mattip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the basic (3.11-dev) CI run is passing.

@mattip

mattip commented Jul 14, 2022

Copy link
Copy Markdown
Member

Thanks @BvB93

@BvB93
BvB93 deleted the alias branch July 14, 2022 12:27
@charris charris changed the title MAINT: Do not let _GenericAlias wrap the underlying classes __class__ attribute MAINT: Do not let _GenericAlias wrap the underlying classes __class__ attribute Jul 24, 2022
@charris charris changed the title MAINT: Do not let _GenericAlias wrap the underlying classes __class__ attribute MAINT: Do not let _GenericAlias wrap the underlying classes' __class__ attribute Jul 24, 2022
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 24, 2022
@charris charris removed this from the 1.23.2 release milestone Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants