Repository navigation
Add missing config.DISABLE_PERFORMANCE_WARNINGS checks - #9794
Merged
swap357 merged 3 commits intoAug 18, 2026
Merged
Conversation
gmarkall
previously requested changes
Nov 18, 2024
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
This looks good to me. A couple of thoughts:
- The CUDA changes will also need porting over to https://github.com/NVIDIA/numba-cuda where continued development of the CUDA target is taking place - if you're happy to, please feel welcome to open a similar PR there. If you'd prefer not to, let me know and I'll open an issue there to add to to the to-do list.
- There aren't really comprehensive tests of disabling the warnings, so it's in keeping with the existing tests that there aren't new tests added here. (Personally I'm OK with this).
- A release note should be added to clarify that the performance warning disabling is fixed in the cases that are missed (see e.g. https://github.com/numba/numba/pull/9768/files#diff-9c273bb73233af5c0d5f335b163965e399d6ca89de3ced932a34157ee9b762f8 for an example of one, and https://github.com/numba/numba/tree/main/docs/upcoming_changes for an explanation of the format)
stuartarchibald
added
2 - In Progress
4 - Waiting on author
maxkapur
force-pushed
the
fix-disable-performance-warnings-simple
branch
from
November 21, 2024 14:37
d94cd8e to
c005d64
Compare
Contributor
Author
|
Thank you for the feedback! I added the release notes. I also went ahead and rebased on Here is a companion PR for numba-cuda: NVIDIA/numba-cuda#70 |
Contributor
Author
|
Hello @gmarkall, wondering if this slipped through the cracks as it still says "waiting for author." |
gmarkall
added
4 - Waiting on reviewer
Contributor
|
Hi @maxkapur, |
…ance-warnings-simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places where Numba raises a
NumbaPerformanceWarningwithout first checking whetherconfig.DISABLE_PERFORMANCE_WARNINGSis enabled, meaning that disabling performance warnings (e.g. using theNUMBA_DISABLE_PERFORMANCE_WARNINGSenvironment variable) fails to silence some warnings.This PR adds these checks.
Closes #9762 (the associated bug).
Closes #9767 (PR providing an alternative solution).