Skip to content

added np.size() overload and added tests #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 11 commits into from
Apr 16, 2024
Merged

added np.size() overload and added tests #9504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6aea86f
added np.size() overload and added tests
shourya5 Mar 19, 2024
0b533fc
fix formatting
shourya5 Mar 19, 2024
8e4fed1
added runners
shourya5 Mar 26, 2024
d24afdf
fix test
shourya5 Mar 26, 2024
438f6a8
fix test
shourya5 Mar 26, 2024
236b3ce
fix test
shourya5 Mar 26, 2024
7003ff0
fix formatting
shourya5 Mar 26, 2024
0ba90da
Update docs/upcoming_changes/9504.np_support.rst
shourya5 Apr 5, 2024
9d8d040
Update numba/tests/test_array_manipulation.py
shourya5 Apr 5, 2024
3178902
Update numba/tests/test_array_manipulation.py
shourya5 Apr 5, 2024
83c1782
Update docs/upcoming_changes/9504.np_support.rst
shourya5 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added runners
  • Loading branch information
@shourya5
shourya5 committed Mar 26, 2024
commit 8e4fed1922f9cf148097b00f6676568c878766c4
4 changes: 4 additions & 0 deletions docs/upcoming_changes/9504.np_support.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
added support for ``np.size()``
====================================================

added ``np.size()`` support for numpy,which was previously unsupported.
Comment thread
shourya5 marked this conversation as resolved.
Resolved
23 changes: 23 additions & 0 deletions numba/tests/test_array_manipulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,6 +1221,29 @@ def check(x):

self.assertIn("The argument to np.shape must be array-like",
str(raises.exception))

def test_size(self):
pyfunc = numpy_size
cfunc = jit(nopython=True)(pyfunc)
Comment thread
shourya5 marked this conversation as resolved.
Resolved

def check(x):
expected = pyfunc(x)
got = cfunc(x)
self.assertPreciseEqual(got, expected)

# check arrays
for t in [(), (1,), (2, 3,), (4, 5, 6)]:
arr = np.empty(t)
check(arr)

# check some types that go via asarray
for t in [1, False, [1,], [[1, 2,],[3, 4]], (1,), (1, 2, 3)]:
check(t)

with self.assertRaises(TypingError) as raises:
cfunc('a')
self.assertIn("The argument to np.size must be array-like",
str(raises.exception))

def test_flatnonzero_basic(self):
pyfunc = numpy_flatnonzero
Expand Down
14 changes: 14 additions & 0 deletions numba/tests/test_record_dtype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,6 +1619,20 @@ def test_shape(self):
cfunc = self.get_cfunc(pyfunc, (ty,))
arr_res = cfunc(arg)
np.testing.assert_equal(arr_res, arr_expected)

def test_size(self):
# test getting the size of a nestedarray inside a record
nbarr = np.recarray(2, dtype=recordwith2darray)
nbarr[0] = np.array([(1, ((1, 2), (4, 5), (2, 3)))],
dtype=recordwith2darray)[0]

arg = nbarr[0]
pyfunc = get_size
ty = typeof(arg)
arr_expected = pyfunc(arg)
cfunc = self.get_cfunc(pyfunc, (ty,))
arr_res = cfunc(arg)
np.testing.assert_equal(arr_res, arr_expected)

def test_corner_slice(self):
# testing corner cases while slicing nested arrays
Expand Down