Repository navigation
Conversation
kc611
marked this pull request as ready for review
February 21, 2024 13:24
gmarkall
reviewed
Feb 26, 2024
|
|
||
| # fix for #8940 | ||
| from numba.np.unsafe import ndarray # noqa F401 | ||
| if numba.core.config.USE_LEGACY_TYPE_SYSTEM: |
Member
There was a problem hiding this comment.
Note for anyone reading this: From discussions with @stuartarchibald - there is presently nothing imported when using the new type system, so that the new implementations can be built up correctly and imports / setup added here piece-by-piece until everything is implemented for the new type system.
(As opposed to starting with everything in the new type system and trying to convert its old behaviour to new behaviour, which would be very hard to do thoroughly and correctly)
This was referenced Feb 26, 2024
Closed
Contributor
Author
|
Closing in favour of #9513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #9408.
It does the same changes except those are changes are being done in entirely new files to prevent any collision with old numba system.