Repository navigation
Remove dependencies between Numba's Cpython and NumPy module - #9437
Merged
Merged
Conversation
…orts in numba.np module to use numba.np.math builtins
kc611
force-pushed
the
independent_modules
branch
from
February 27, 2024 14:35
d3f81f8 to
7220c79
Compare
sklam
self-requested a review
February 27, 2024 14:44
sklam
reviewed
Feb 27, 2024
Member
|
File history look ok under git blame |
sklam
added
4 - Waiting on author
kc611
added
4 - Waiting on reviewer
sklam
added
4 - Waiting on author
kc611
added
4 - Waiting on reviewer
sklam
added
4 - Waiting on author
…t for further reference
kc611
added
4 - Waiting on reviewer
sklam
reviewed
Mar 1, 2024
|
|
||
| from numba.core.imputils import impl_ret_untracked | ||
| from numba.core import typing, types, errors, cgutils | ||
| from numba.cpython.unsafe.numbers import viewer |
Member
There was a problem hiding this comment.
This will require a np version, but the change can be done later in subsequent PRs. viewer is only used by scalar_view which is the implementation for np.view. In this file, the registration is commented out. So, this line is effectively dead.
sklam
added
4 - Waiting on author
Co-authored-by: Siu Kwan Lam <1929845+sklam@users.noreply.github.com>
kc611
added
4 - Waiting on reviewer
sklam
approved these changes
Mar 4, 2024
sklam
added
5 - Ready to merge
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled.
This PR intends to remove dependency of Cpython module on NumPy module and adds independent builtins that are seperate for NumPy and Cpython modules.