Skip to content

Add math.log2 support #9416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 4 commits into from
Mar 15, 2024
Merged

Add math.log2 support #9416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10ec751
Add math.log2 support
guilhermeleobas Feb 2, 2024
314381f
add release notes
guilhermeleobas Feb 2, 2024
10ca4a6
address reviewer comments
guilhermeleobas Feb 16, 2024
a819f10
Fix release notes
guilhermeleobas Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add math.log2 support
  • Loading branch information
@guilhermeleobas
guilhermeleobas committed Feb 2, 2024
commit 10ec7519c26d030637476b285d6b8f9ad467d393
1 change: 1 addition & 0 deletions numba/core/typing/mathdecl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
@infer_global(math.log)
@infer_global(math.log1p)
@infer_global(math.log10)
@infer_global(math.log2)
@infer_global(math.sin)
@infer_global(math.cos)
@infer_global(math.tan)
Expand Down
1 change: 1 addition & 0 deletions numba/cpython/mathimpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ def float_impl(context, builder, sig, args):
exp_impl = unary_math_intr(math.exp, 'llvm.exp')
log_impl = unary_math_intr(math.log, 'llvm.log')
log10_impl = unary_math_intr(math.log10, 'llvm.log10')
log2_impl = unary_math_intr(math.log2, 'llvm.log2')

@stuartarchibald stuartarchibald Feb 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this implementation should raise ValueError('math domain error') for input values that are zero or negative, however, what is present is no different to e.g. log10 above which would suffer from the same issue.

@guilhermeleobas guilhermeleobas Feb 16, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can tackle this in a follow-up PR if needed.

sin_impl = unary_math_intr(math.sin, 'llvm.sin')
cos_impl = unary_math_intr(math.cos, 'llvm.cos')

Expand Down
12 changes: 12 additions & 0 deletions numba/tests/test_mathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ def log10(x):
return math.log10(x)


def log2(x):
return math.log2(x)


def floor(x):
return math.floor(x)

Expand Down Expand Up @@ -285,6 +289,14 @@ def test_log10(self):
x_values = [1, 10, 100, 1000, 100000, 1000000, 0.1, 1.1]
self.run_unary(pyfunc, x_types, x_values)

def test_log2(self):
pyfunc = log2
x_types = [types.int16, types.int32, types.int64,
types.uint16, types.uint32, types.uint64,
types.float32, types.float64]
x_values = [1, 10, 100, 1000, 100000, 1000000, 0.1, 1.1]
self.run_unary(pyfunc, x_types, x_values)

def test_asin(self):
pyfunc = asin
x_types = [types.int16, types.int32, types.int64,
Expand Down