Skip to content

Release notes fixes for appropriate Towncrier header underlines - #9364

Merged
sklam merged 4 commits into
numba:mainfrom
kc611:towncrier_fixes
Feb 9, 2024
Merged

sklam merged 4 commits into
numba:mainfrom
kc611:towncrier_fixes

Conversation

@kc611

@kc611 kc611 commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

As titled.

Comment thread docs/upcoming_changes/9249.np_support.rst Outdated
@kc611 kc611 added the skip_release_notes Skip towncrier requirement label Dec 15, 2023
@kc611 kc611 closed this Dec 15, 2023
@kc611 kc611 reopened this Dec 15, 2023
@esc

esc commented Dec 18, 2023

Copy link
Copy Markdown
Member

Should this be part of 0.59.0rc2/0.59.0?

@esc

esc commented Jan 10, 2024 •

Copy link
Copy Markdown
Member

I've added this to the 0.59.0 milestone

@sklam

sklam commented Jan 22, 2024

Copy link
Copy Markdown
Member

We discussed this earlier and we don't need it for 0.59. This should be merged to main without cherrypicking to 0.59. I'm moving this to 0.60. We should merge this after 0.59.

@sklam sklam modified the milestones: 0.59.0, 0.60.0-rc1 Jan 22, 2024

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the doc build. It looks correct.

@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Jan 22, 2024
@esc

esc commented Jan 29, 2024

Copy link
Copy Markdown
Member

@kc611 @sklam thanks for contribution and review!

@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Feb 7, 2024
@sklam
sklam merged commit 51e5376 into numba:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge skip_release_notes Skip towncrier requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants