Skip to content

Introduce internal _isinstance_no_warn #8947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esc merged 6 commits into from
Jun 5, 2023
Merged

Introduce internal _isinstance_no_warn #8947

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e98f16f
introduce _isinstance_no_warn
guilhermeleobas May 5, 2023
305edd5
find overloads that use isinstance
guilhermeleobas May 5, 2023
b1af18d
remove assert
guilhermeleobas May 5, 2023
efd89a1
wrongly replaced isinstance by _isinstance_no_warn
guilhermeleobas May 5, 2023
54759d7
add test
guilhermeleobas May 26, 2023
bbac1d0
adding method string to test for future removal
esc May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wrongly replaced isinstance by _isinstance_no_warn
  • Loading branch information
@guilhermeleobas
guilhermeleobas committed May 5, 2023
commit efd89a1650185e88ad1060e9ccdfd78d021650a1
6 changes: 2 additions & 4 deletions numba/np/arraymath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3371,17 +3371,15 @@ def ov_np_where_x_y(condition, x, y):
x_arr = isinstance(x, types.Array)
y_arr = isinstance(y, types.Array)

from numba.cpython.builtins import _isinstance_no_warn

if cond_arr:
x_dt = determine_dtype(x)
y_dt = determine_dtype(y)
dtype = np.promote_types(x_dt, y_dt)

# corner case - 0 dim values
def check_0_dim(arg):
return _isinstance_no_warn(arg, types.Number) or (
_isinstance_no_warn(arg, types.Array) and arg.ndim == 0)
return isinstance(arg, types.Number) or (
isinstance(arg, types.Array) and arg.ndim == 0)
special_0_case = all([check_0_dim(a) for a in (condition, x, y)])
if special_0_case:
return _where_zero_size_array_impl(dtype)
Expand Down