Skip to content

Revise CUDA deprecation notices - #8866

Merged
sklam merged 2 commits into
numba:mainfrom
gmarkall:cuda-50-undeprecation
Mar 30, 2023
Merged

Revise CUDA deprecation notices#8866
sklam merged 2 commits into
numba:mainfrom
gmarkall:cuda-50-undeprecation

Conversation

@gmarkall

@gmarkall gmarkall commented Mar 30, 2023

Copy link
Copy Markdown
Member

Based on #8864 to avoid a merge conflict shortly.

  • Revise deprecation of CC to < 5.0.
  • Note removal of CTK < 11.2 support (this is not new per se, just in keeping with the usual schedule of dropping support for old toolkits).

gmarkall added 2 commits March 30, 2023 17:00
@gmarkall
Remove obsolete deprecation notices
a8942e6 
- Eager compilation of device functions
- Removal of `add_user_function()`
@gmarkall
Revise deprecation of CC to < 5.0 - note removal of CTK 11.2 support …
da90ee8 
…in future
@gmarkall gmarkall added doc CUDA CUDA related issue/PR labels Mar 30, 2023
@gmarkall gmarkall added this to the Numba 0.57 RC milestone Mar 30, 2023
@gmarkall

gmarkall commented Mar 30, 2023

Copy link
Copy Markdown
Member Author

gpuci run tests

stuartarchibald
stuartarchibald approved these changes Mar 30, 2023
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I've grepped the code base for "5.3" and "5..3" and nothing appeared that hasn't been fixed up by the patch da90ee8. Patch a8942e6 has been reviewed in #8864 already.

@stuartarchibald stuartarchibald added the 4 - Waiting on CI Review etc done, waiting for CI to finish label Mar 30, 2023
@stuartarchibald stuartarchibald mentioned this pull request Mar 30, 2023
Closed
41 of 44 tasks
@stuartarchibald

stuartarchibald commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_195.

@stuartarchibald stuartarchibald added the Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm label Mar 30, 2023
@stuartarchibald

stuartarchibald commented Mar 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Manual testing of this patch on a CC=5.2 device passed with all tests in numba.cuda.tests ok with the exception of this one: #8867 (unrelated failure due to use of Python 3.11).

@sklam

sklam commented Mar 30, 2023

Copy link
Copy Markdown
Member

Buildfarm ID: numba_smoketest_cuda_yaml_195.

passed

@sklam sklam added BuildFarm Passed For PRs that have been through the buildfarm and passed 5 - Ready to merge Review and testing done, is ready to merge and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI Review etc done, waiting for CI to finish labels Mar 30, 2023
@sklam
sklam merged commit 62fa8f0 into numba:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@sklam sklam Awaiting requested review from sklam

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR doc

Projects

None yet

Milestone

Numba 0.57 RC

Development

Successfully merging this pull request may close these issues.

3 participants

@gmarkall @stuartarchibald @sklam