Repository navigation
Disable SLP vectorisation due to miscompilations. - #8852
Merged
Merged
Conversation
This switches off SLP vectorisation by default due to reported and confirmed miscompilations. It fixes up the SLP vectorisation checking unit test by running it in a subprocess with SLP enabled so as to isolate any potential issues. Docs and config defaults are updated. xref numba#8705 numba#8681
stuartarchibald
added
3 - Ready for Review
Effort - short
stuartarchibald
marked this pull request as ready for review
March 27, 2023 17:01
sklam
approved these changes
Mar 27, 2023
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches off SLP vectorisation by default due to reported and confirmed miscompilations. It fixes up the SLP vectorisation checking unit test by running it in a subprocess with SLP enabled so as to isolate any potential issues. Docs and config defaults are updated.
xref #8705 #8681