Repository navigation
Ensure gc.collect() is called before checking refcount in tests. - #8781
Merged
Merged
Conversation
Closed
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Couple of minor things else looks good, thanks for moving this patch to a separate PR @sklam.
sklam
force-pushed
the
fix/refcount_gc_collect
branch
from
February 24, 2023 18:11
4a47b98 to
70cedbc
Compare
sklam
marked this pull request as ready for review
February 24, 2023 18:13
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Mar 6, 2023
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitted from #8776 (comment) as requested by reviewer.