Skip to content

Revert PR#8751 for buildfarm stability - #8775

Merged
sklam merged 1 commit into
numba:mainfrom
sklam:fix/main_ci
Feb 23, 2023
Merged

sklam merged 1 commit into
numba:mainfrom
sklam:fix/main_ci

Conversation

@sklam

@sklam sklam commented Feb 22, 2023 •

Copy link
Copy Markdown
Member

Revert "Merge pull request #8751 from apmasell/mulitprocess_recycling" as an attempt to establish the baseline.

#8751 exposed many latent bug in the testsuite and fixing all of them may take a while. That's why I suggest revert the PR for now and continue to fix the problems in #8776.

@sklam

sklam commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

numba_smoketest_cpu_yaml_164

@sklam

sklam commented Feb 22, 2023

Copy link
Copy Markdown
Member Author

all linux x64 and ppc64le platforms have passed.

@sklam sklam added the abandoned PR is abandoned (no reason required) label Feb 22, 2023
@sklam sklam changed the title [CI ONLY] debugging buildfarm Revert PR#8751 for buildfarm stability Feb 23, 2023
@sklam
sklam marked this pull request as ready for review February 23, 2023 16:15
@sklam sklam added 3 - Ready for Review and removed abandoned PR is abandoned (no reason required) labels Feb 23, 2023
@sklam

sklam commented Feb 23, 2023

Copy link
Copy Markdown
Member Author

BFID: numba_yaml_312

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the patch. As discussed OOB, this should stabilise the build and create a point from which this change (and the potential bugs it exposed) can be explored again.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels Feb 23, 2023
@stuartarchibald stuartarchibald added this to the Numba 0.57 RC milestone Feb 23, 2023
@stuartarchibald stuartarchibald added the Effort - short Short size effort needed label Feb 23, 2023
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Feb 23, 2023
@sklam

sklam commented Feb 23, 2023

Copy link
Copy Markdown
Member Author

BFID: numba_yaml_312

Buildfarm is stable enough with this PR. Merging

@sklam
sklam merged commit 7b2637f into numba:main Feb 23, 2023
@sklam
sklam deleted the fix/main_ci branch February 23, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants