Repository navigation
Update vendored Versioneer from 0.14 to 0.28 - #8771
Merged
Merged
Conversation
This is primarily done to remove its distutils dependency. Per the upgrade notes (see https://github.com/python-versioneer/python-versioneer/blob/master/UPGRADING.md), the configuration of Versioneer is moved into `setup.cfg` from `setup.py`. The other notes on upgrading between Versions 0.14 and 0.28 don't apply to our particular configuration as we're not presently using pyproject.toml. `versioneer.py` is also added to the Flake8 ignore list, as its format no longer conforms to our rules.
gmarkall
added
3 - Ready for Review
2 - In Progress
and removed
3 - Ready for Review
labels
gmarkall
force-pushed
the
versioneer-028
branch
from
February 20, 2023 15:32
80288b4 to
36527f3
Compare
Member
Author
|
gpuci run tests |
sklam
approved these changes
Mar 9, 2023
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
Thanks for the patch. I have also tested this on py3.11 branch
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily done to remove its distutils dependency.
Per the upgrade notes (see https://github.com/python-versioneer/python-versioneer/blob/master/UPGRADING.md), the configuration of Versioneer is moved into
setup.cfgfromsetup.py.The other notes on upgrading between Versions 0.14 and 0.28 don't apply to our particular configuration as we're not presently using
pyproject.toml.versioneer.pyis also added to the Flake8 ignore list, as its format no longer conforms to our rules.Note that there are other options we could consider, including:
However, as I'm not aware of any issues with our current setup / approach, I think this PR is the simplest way forward with minimum effort to help get us away from having a distutils dependency.
Changes to
numba/_version.pyandversioneer.pywere made by Versioneer, when I ran theversioneer installcommand as per Updating Versioneer.This also includes @oscargus's fix from #7765 that updates
inspector._get_commit()for recent versions of Versioneer. Note that this PR updates to version 0.28, whereas #7765 updates to 0.22 (which I believe was current at the time).