Skip to content

Suppress known test failures for py3.11 - #8748

Merged
sklam merged 3 commits into
numba:py3.11from
sklam:misc/suppress_error_py311
Feb 15, 2023
Merged

Suppress known test failures for py3.11#8748
sklam merged 3 commits into
numba:py3.11from
sklam:misc/suppress_error_py311

Conversation

@sklam

@sklam sklam commented Feb 9, 2023

Copy link
Copy Markdown
Member
  • add expectedFailure to try-except and with-lifting tests
  • reduce test accuracy for test_pow

@sklam
Suppress known test failure for py3.11
08acc87 
- add expectedFailure to try-except and with-lifting tests
- reduce test accuracy for test_pow
@sklam
sklam force-pushed the misc/suppress_error_py311 branch from a3f9cad to 08acc87 Compare February 9, 2023 22:27
@sklam sklam mentioned this pull request Feb 10, 2023
Merged
@stuartarchibald stuartarchibald added 2 - In Progress Python 3.11 All issues related to Python 3.11 support labels Feb 15, 2023
@stuartarchibald

stuartarchibald commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Closed and reopened to get a rebuild against py3.11 branch with #8752 now present.

@stuartarchibald

stuartarchibald commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This patch reduces the reported Python 3.11 related test failures to the following:

stuartarchibald
stuartarchibald reviewed Feb 15, 2023
View reviewed changes
Comment thread numba/tests/test_operators.py Outdated
Comment on lines +1314 to +1315
if utils.PYVERSION == (3, 11):
extra_cast = dict(force_type=float)

@stuartarchibald stuartarchibald Feb 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an else branch needed to define extra_cast else this will fail on < 3.11 with a NameError?

Another option to "fix" this would be to just restrict the input on 3.11 to numerically smaller values. As noted in the comments, there are already challenges present in the inputs/testing/implementation.

@sklam sklam Feb 15, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, i'll fix that. and check if smaller numbers make a easier fix.

@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review and removed 2 - In Progress labels Feb 15, 2023
@stuartarchibald stuartarchibald added this to the Numba 0.57 RC milestone Feb 15, 2023
@sklam

sklam commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I still need to suppress this. Will probably make it expected failure for now just to get a good baseline.

@sklam
sklam marked this pull request as ready for review February 15, 2023 16:56
stuartarchibald
stuartarchibald approved these changes Feb 15, 2023
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review 4 - Waiting on CI Review etc done, waiting for CI to finish labels Feb 15, 2023
@sklam

sklam commented Feb 15, 2023

Copy link
Copy Markdown
Member Author

#8761 passing shows that this PR work

@sklam
sklam merged commit 67857fb into numba:py3.11 Feb 15, 2023
@sklam
sklam deleted the misc/suppress_error_py311 branch February 15, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge Python 3.11 All issues related to Python 3.11 support

Projects

None yet

Milestone

Numba 0.57 RC

Development

Successfully merging this pull request may close these issues.

2 participants

@sklam @stuartarchibald