Repository navigation
Update bot to close PRs waiting on authors for more than 3 months - #8735
Conversation
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for making these changes @guilhermeleobas, couple of queries to resolve else looks good.
| This pull request is marked as stale as it has had no activity in | ||
| the past 6 months. Please respond to this comment if you're still | ||
| interested in working on this. | ||
| days-before-pr-stale: 90 # 3 months | ||
| days-before-pr-close: 90 |
There was a problem hiding this comment.
The message text refers to 6 months, but the days before for stale is 3 months (90 days)? Also, is there an option to set a message for when it's closed?
There was a problem hiding this comment.
Fixed.
Also, is there an option to set a message for when it's closed?
This is the message that will show up. See https://github.com/actions/stale#stale-pr-message
| days-before-pr-stale: 90 # 3 months | ||
| days-before-pr-close: 90 | ||
| any-of-pr-labels: '2 - In progress,4 - Waiting on author' | ||
| stale-pr-label: 'abandoned' |
There was a problem hiding this comment.
When is this label applied? At the point it is considered "stale"? If so, should it be labelled "stale" at this point and then "abandoned" once it is actually closed?
stuartarchibald
added
4 - Waiting on author
guilhermeleobas
added
4 - Waiting on reviewer
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the fixes @guilhermeleobas, I think this achieves what was agreed by the FPOC group a few weeks back but someone else ought to take a look too.
stuartarchibald
added
the
4 - Waiting on second reviewer
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
sklam
added
5 - Ready to merge
3 participants
Following some recent discussion on Numba public meeting. It was decided that we will close PRs waiting for author response for more than 3 months. Since we already had a bot for staling PRs, I just updated it to accommodate the new changes.