Repository navigation
Make external compiler discovery lazy in the test suite. - #8661
Merged
Merged
Conversation
This aims to make it so that external compilers are only probed when absolutely necessary and that the result of the probe is cached. This should speed up initialisation of the testing framework and consequently speed up tests running in subprocesses.
stuartarchibald
marked this pull request as ready for review
December 9, 2022 14:59
stuartarchibald
added
3 - Ready for Review
Effort - short
gmarkall
reviewed
Jan 3, 2023
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.skip_if_no_external_compiler() # external compiler needed |
Member
There was a problem hiding this comment.
I just checked whether it's OK to call skipTest() in a setUp() method, and it is: https://docs.python.org/3/library/unittest.html#skipping-tests-and-expected-failures
sklam
reviewed
Jan 9, 2023
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
Manually verified that the external_compiler_works is now lazy.
There's just one nitpick regarding an empty line added.
| @needs_external_compilers | ||
| class TestDistutilsSupport(TestCase): | ||
|
|
||
|
|
sklam
added
4 - Waiting on author
As title.
stuartarchibald
added
4 - Waiting on reviewer
sklam
approved these changes
Jan 10, 2023
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to make it so that external compilers are only probed when absolutely necessary and that the result of the probe is cached. This should speed up initialisation of the testing framework and consequently speed up tests running in subprocesses.