Repository navigation
Setup Azure CI to test py3.11 - #8598
Merged
Merged
Conversation
sklam
added
3 - Ready for Review
Python 3.11
sklam
marked this pull request as ready for review
November 11, 2022 23:32
stuartarchibald
approved these changes
Nov 14, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch. There's some superfluous changes with respect to windows builds (given this targets linux only), but as discussed OOB this patch is going to be reverted on the py3.11 development branch prior to merge to main as it is just to get some testing/feedback running.
Seems like the only difference between this patch and 3c31427 from #8595 is this:
< if [[ "$(uname -s)" == *"Linux"* ]] && [[ "$(uname -p)" == *"86"* ]]; then
< EXTRA_BUILD_EXT_FLAGS="--werror --wall"
---
> # if [[ "$(uname -s)" == *"Linux"* ]] && [[ "$(uname -p)" == *"86"* ]]; then
> # EXTRA_BUILD_EXT_FLAGS="--werror --wall"whereby this patch does not comment out the build-with-warnings-as-errors flags, which is probably a good thing!
stuartarchibald
added
5 - Ready to merge
Contributor
|
Note: The build is expected to fail, this PR is changing public CI to start working with Python 3.11 exclusively on the merge target branch of |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(closes #8595)