LLVM14 by apmasell · Pull Request #8535 · numba/numba

apmasell · 2022-10-24T18:08:52Z

No description provided.

gmarkall · 2022-11-29T11:44:05Z

/azp run

azure-pipelines · 2022-11-29T11:44:16Z

Azure Pipelines successfully started running 1 pipeline(s).

apmasell · 2022-12-05T12:34:41Z

/azp run

azure-pipelines · 2022-12-05T12:34:47Z

Commenter does not have sufficient privileges for PR 8535 in repo numba/numba

sklam · 2023-02-03T20:33:49Z

#8738 documents why we cannot use llvm14 on linux-aarch64

sklam · 2023-02-07T20:11:06Z

    - importlib_metadata       # [py<39]
    # On channel https://anaconda.org/numba/
-    - llvmlite >=0.40.0dev0,<0.40
+    - llvmlite >=0.40.0dev0llvm14,<0.40


Do we need to split build of llvmlite on aarch64 to use llvm11? Or, can we just say we stay on llvmlite 0.39? This is something we should decide @numba/fpoc

Need a revert on this

sklam

Just one suggestion on adding a test for fanout_raise refpruning. Beside needing decision on how to move forward for llvm14/11 split builds. Everything else looks good.

sklam · 2023-02-08T23:15:12Z

I tested this patch with LLVM11 (with _ensure_llvm disabled) on x86 as a guess-estimate of problems on linux-aarch64. Ignoring failures that are testing llvmlite version (numba.tests.test_llvm_version_check.TestLlvmVersion.test_llvmlite_version) and tests that are specific to x64 (numba.tests.test_vectorization.TestVectorization), everything else is ok.

As titled

As titled. Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>

stuartarchibald · 2023-02-23T17:31:44Z

NOTE: the table here will need an update in the LLVM version column:

numba/docs/source/user/installing.rst

Line 260 in 135d150

    
           | 0.57.x    | TBC          | 3.8.x <= version < 3.12   | 1.19 <= version < 1.24     | 0.40.x                       | 11.x              | 2021.x                      |

As titled.

sklam · 2023-03-08T17:59:26Z


 _min_llvmlite_version = (0, 40, 0)
-_min_llvm_version = (11, 0, 0)
+_min_llvm_version = (14, 0, 0)


This needs to be conditional on the platform due to linux-aarch64 split build.

I think should be just 11. We're theoretically fine with LLVM 11 on any platform, right?

As titled.

sklam · 2023-03-10T16:00:12Z

@apmasell, this PR needs a merge main to resolve conflicts

gmarkall · 2023-03-13T10:32:50Z

gpuci run tests

stuartarchibald · 2023-03-13T13:29:17Z

+                pm.add_cfg_simplification_pass()
+            else:
+                pm.add_instruction_combining_pass()
+                pm.add_jump_threading_pass()


Please could a comment be added explaining what the problem was and why this fixes it? Thanks!

sklam · 2023-03-13T18:09:17Z

I tested this branch against the latest llvmlite package at #8807 and it passed (except windows are failing due to timeout)

sklam

A few more comments need address before merging, including #8535 (comment)
and mainly reverting the change in the llvmlite version.

sklam · 2023-03-13T18:11:19Z

    - importlib_metadata       # [py<39]
    # On channel https://anaconda.org/numba/
-    - llvmlite >=0.40.0dev0,<0.40
+    - llvmlite >=0.40.0dev0llvm14,<0.40


Need a revert on this

sklam · 2023-03-13T18:11:26Z

 call activate %CONDA_ENV%
 @rem Install latest llvmlite build
-%CONDA_INSTALL% -c numba/label/dev llvmlite=0.40
+%CONDA_INSTALL% -c numba/label/dev "llvmlite=0.40.0dev0llvm14*"


Need a revert on this

sklam · 2023-03-13T18:11:30Z


 # Install latest correct build
-$CONDA_INSTALL -c numba/label/dev llvmlite=0.40
+$CONDA_INSTALL -c numba/label/dev "llvmlite=0.40.0dev0llvm14*"


Need a revert on this

sklam · 2023-03-13T18:13:16Z

+            self.check(func, (types.intp), basicblock=True, diamond=False,
+                       fanout=True, fanout_raise=False)
+
+    def test_fanout_3(self):


Do we need to skip this for linux-aarch64 or just when llvm version == 11?

As longa s we're using a new llvmlite, I think this should work.

As titled.

sklam · 2023-03-13T19:34:58Z

Builds are failing expectedly because they are picking up the old llvmlite build

apmasell requested review from sklam and stuartarchibald as code owners October 24, 2022 18:08

apmasell added the 2 - In Progress label Oct 24, 2022

apmasell requested a review from gmarkall as a code owner January 31, 2023 21:38

apmasell added 2 commits February 2, 2023 13:59

LLVM14

5ecf0d4

DO NOT MERGE: LLVM14 TESTING INFRASTRUCTURE

f0e9adb

apmasell added 3 - Ready for Review and removed 2 - In Progress labels Feb 2, 2023

sklam reviewed Feb 7, 2023

View reviewed changes

sklam reviewed Feb 8, 2023

View reviewed changes

Comment thread numba/tests/test_refop_pruning.py

Add additional refprune test

5b45803

As titled

stuartarchibald reviewed Feb 15, 2023

View reviewed changes

Comment thread numba/tests/test_debuginfo.py Outdated

Use better assertion logic

08c3366

As titled. Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>

stuartarchibald added the Effort - long Long size effort needed label Feb 23, 2023

stuartarchibald added this to the Numba 0.57 RC milestone Feb 23, 2023

Change LLVM version in documentation

1e42a0b

As titled.

sklam reviewed Mar 8, 2023

View reviewed changes

Allow LLVM 14 for Linux AArch64 compatibility

e09828b

As titled.

Merge remote-tracking branch 'origin/main' into llvm14

1f22e7a

stuartarchibald reviewed Mar 13, 2023

View reviewed changes

sklam reviewed Mar 13, 2023

View reviewed changes

sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Mar 13, 2023

apmasell added 3 commits March 13, 2023 14:48

Remove LLVM14 build scaffolding

bcf35f2

As titled.

Add documentation for LLVM 14 passes

7dd0ab6

As titled.

Remove more LLVM 14 build scaffolding

03cf859

As titled.

sklam approved these changes Mar 13, 2023

View reviewed changes

sklam added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Mar 13, 2023

sklam merged commit c66a986 into numba:main Mar 13, 2023

sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Mar 13, 2023

apmasell deleted the llvm14 branch March 13, 2023 19:37

apmasell mentioned this pull request Mar 13, 2023

Update LLVM versions for 0.57 release #8809

Merged

dlee992 mentioned this pull request Sep 7, 2023

[Discuss] generates extra branches in LLVM IR 0.57.1 #9186

Closed

dlee992 mentioned this pull request Dec 8, 2023

Support non-constant exception values in JIT #8134

Merged

dlee992 mentioned this pull request Apr 29, 2024

add emit_excinfo_store_with_md for all excinfo-related store instructions #9551

Closed

Conversation

apmasell commented Oct 24, 2022

Uh oh!

gmarkall commented Nov 29, 2022

Uh oh!

azure-pipelines Bot commented Nov 29, 2022

Uh oh!

apmasell commented Dec 5, 2022

Uh oh!

azure-pipelines Bot commented Dec 5, 2022

Uh oh!

sklam commented Feb 3, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sklam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sklam commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stuartarchibald commented Feb 23, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sklam commented Mar 10, 2023

Uh oh!

gmarkall commented Mar 13, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sklam commented Mar 13, 2023

Uh oh!

sklam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sklam commented Mar 13, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sklam commented Feb 8, 2023 •

edited

Loading

sklam left a comment •

edited

Loading