Repository navigation
Restore installing SciPy from defaults instead of conda-forge on public CI - #8490
Merged
Merged
Conversation
esc
changed the title
esc
force-pushed
the
public_ci/remove_scipy_cf
branch
from
October 5, 2022 08:22
5b50559 to
0868018
Compare
stuartarchibald
previously approved these changes
Oct 5, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
stuartarchibald
added
4 - Waiting on CI
sklam
added
4 - Waiting on author
Member
|
there are merge conflict |
…ic CI This fixes fetching SciPy from defaults instead of conda-forge, now that a suitable SciPy 1.9 has become available. This is a partial revert of numba#8413 since only the changes for the public ci build scripts, that pertain to the installation of SciPy are included.
esc
force-pushed
the
public_ci/remove_scipy_cf
branch
from
October 6, 2022 08:41
0868018 to
9d250c4
Compare
Member
Author
|
@sklam @stuartarchibald I opted to rebase onto |
esc
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Oct 6, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Re-approved, thanks @esc!
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes fetching SciPy from defaults instead of conda-forge, now that a suitable SciPy 1.9 has become available.
This is a partial revert of #8413 since only the changes for the public ci build scripts, that pertain to the installation of SciPy are included.