Skip to content

remove GitHub username from changelog generation script - #8450

Merged
sklam merged 1 commit into
numba:mainfrom
esc:remove_username_from_changelog
Sep 28, 2022
Merged

sklam merged 1 commit into
numba:mainfrom
esc:remove_username_from_changelog

Conversation

@esc

@esc esc commented Sep 20, 2022

Copy link
Copy Markdown
Member

This modifies the changelog such that the configured username isn't used. Only the user login is used.

If the login is maxm and the configured username is Max Mustermann, the changelog entry would have contained:

(`Max Mustermann  <https://github.com/maxm>`_)

And with this change the entry would now contain:

(`maxm  <https://github.com/maxm>`_)

This modifies the changelog such that the configured username isn't
used. Only the user login is used.

If the login is `maxm` and the configured username is `Max Mustermann`,
the changelog entry would have contained:

```
(`Max Mustermann  <https://github.com/maxm>`_)
```

And with this change the entry would now contain:

```
(`maxm  <https://github.com/maxm>`_)
```
@esc

esc commented Sep 20, 2022

Copy link
Copy Markdown
Member Author

Fixes #8437

@esc esc added the Effort - short Short size effort needed label Sep 20, 2022
@guilhermeleobas guilhermeleobas self-assigned this Sep 21, 2022

@guilhermeleobas guilhermeleobas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried locally and it is working as expected

@guilhermeleobas guilhermeleobas added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Sep 27, 2022
@sklam sklam added this to the Numba 0.57 RC milestone Sep 28, 2022
@sklam
sklam merged commit 96989df into numba:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants