Repository navigation
remove GitHub username from changelog generation script - #8450
Merged
Merged
Conversation
This modifies the changelog such that the configured username isn't used. Only the user login is used. If the login is `maxm` and the configured username is `Max Mustermann`, the changelog entry would have contained: ``` (`Max Mustermann <https://github.com/maxm>`_) ``` And with this change the entry would now contain: ``` (`maxm <https://github.com/maxm>`_) ```
Member
Author
|
Fixes #8437 |
guilhermeleobas
approved these changes
Sep 27, 2022
guilhermeleobas
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Tried locally and it is working as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the changelog such that the configured username isn't used. Only the user login is used.
If the login is
maxmand the configured username isMax Mustermann, the changelog entry would have contained:And with this change the entry would now contain: