Repository navigation
Update the contributing docs to include a policy on formatting changes. - #8439
Merged
Merged
Conversation
This updates the contributing docs to highlight that Numba's policy on large scale formatting changes is to not accept such patches. It removes the fix a file to be flake8 compliant suggestion and adds a link to the time boxed tasks available on the self-service board.
stuartarchibald
marked this pull request as ready for review
September 14, 2022 16:52
stuartarchibald
added
3 - Ready for Review
Effort - short
gmarkall
reviewed
Nov 8, 2022
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
I've left a couple of comments on the diff - what do you think?
As title. Co-authored-by: Graham Markall <535640+gmarkall@users.noreply.github.com>
stuartarchibald
added
4 - Waiting on reviewer
Contributor
Author
Thanks for the review, both changes are accepted in b024011. |
gmarkall
approved these changes
Nov 8, 2022
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
Thanks for the updated policy - it looks good to me. I've checked that this renders well on RTD also.
gmarkall
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the contributing docs to highlight that Numba's policy on large scale formatting changes is to not accept such patches. It removes the fix a file to be flake8 compliant suggestion and adds a link to the time boxed tasks available on the self-service board.