Repository navigation
Migrate np.atleast_? functions from glue_lowering to overload - #8435
Merged
Merged
Conversation
Change the implementation of these functions to use the new overload definition mechanism
stuartarchibald
changed the title
np.atlesast_? functions from glue_lowering to overloadnp.atleast_? functions from glue_lowering to overload
guilhermeleobas
previously approved these changes
Oct 7, 2022
guilhermeleobas
left a comment
guilhermeleobas
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @apmasell
Contributor
|
@apmasell there's a merge conflict |
As titled.
Contributor
Author
|
I've fixed the merge conflict. |
guilhermeleobas
approved these changes
Oct 11, 2022
guilhermeleobas
added
4 - Waiting on second reviewer
stuartarchibald
approved these changes
Oct 18, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, I've tested this locally and have looked through the changes in logic, seems correct on inspection.
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the implementation of these functions to use the new overload definition mechanism