Repository navigation
Replace @overload_glue by @overload for np.linspace and np.take - #8431
Merged
Merged
Conversation
guilhermeleobas
changed the title
@overload_glue by @overload for np.linspace and np.take
guilhermeleobas
marked this pull request as ready for review
September 10, 2022 05:05
guilhermeleobas
requested review from
sklam and
stuartarchibald
as code owners
September 10, 2022 05:05
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this refactoring @guilhermeleobas, couple of minor things to resolve else looks good.
| dtype = types.float64 | ||
| dtype = as_dtype(dtype) | ||
|
|
||
| # Implementation based on https://github.com/numpy/numpy/blob/v1.20.0/numpy/core/function_base.py#L24 # noqa: E501 |
Contributor
There was a problem hiding this comment.
This reference should be maintained?
stuartarchibald
added
4 - Waiting on author
guilhermeleobas
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Sep 13, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #8254
Change
np.takeandnp.linspaceto use@overload