Repository navigation
Post 0.56.2 cleanup - #8425
Merged
Merged
Post 0.56.2 cleanup#8425
Conversation
Hotfix for 0.56.2
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this clean up @esc, couple of minor comments to resolve else looks good.
| * PR `#8413 <https://github.com/numba/numba/pull/8413>`_: Fix Azure CI for NumPy 1.23 and use conda-forge scipy (`Siu Kwan Lam <https://github.com/sklam>`_) | ||
| * PR `#8414 <https://github.com/numba/numba/pull/8413>`_: Hotfix for 0.56.2 (`Siu Kwan Lam <https://github.com/sklam>`_) | ||
|
|
||
| Version 0.56.1 (1 September, 2022) |
Contributor
There was a problem hiding this comment.
Should this also say "NO RELEASE" for the release date?
| * PR `#8412 <https://github.com/numba/numba/pull/8412>`_: Create changelog for 0.56.1 (`Andre Masella <https://github.com/apmasell>`_) | ||
| * PR `#8413 <https://github.com/numba/numba/pull/8413>`_: Fix Azure CI for NumPy 1.23 and use conda-forge scipy (`Siu Kwan Lam <https://github.com/sklam>`_) | ||
| * PR `#8414 <https://github.com/numba/numba/pull/8413>`_: Hotfix for 0.56.2 (`Siu Kwan Lam <https://github.com/sklam>`_) | ||
|
|
Contributor
There was a problem hiding this comment.
The authors list needs adding?
stuartarchibald
added
4 - Waiting on author
Member
Author
|
@stuartarchibald thank you for the review, I have addressed all the comments accordingly. |
Comment on lines
+33
to
+34
| Version 0.56.1 (NO RELEASE) | ||
| ---------------------------------- |
Contributor
There was a problem hiding this comment.
Suggested change
| Version 0.56.1 (NO RELEASE) | |
| ---------------------------------- | |
| Version 0.56.1 (NO RELEASE) | |
| --------------------------- |
Underline line length doesn't match length of the thing it's underlining? Expect the CI doc build will pick this up.
As title
stuartarchibald
approved these changes
Sep 7, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch!
stuartarchibald
added
4 - Waiting on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial cherry-pick of #8414 -- without the pin for NumPy. This then also includes the changes originally proposed in #8419.