Skip to content

Remove Cuda toolkit version check - #8401

Merged
esc merged 3 commits into
numba:mainfrom
testhound:testhound/remove_get_version_check
Sep 7, 2022
Merged

esc merged 3 commits into
numba:mainfrom
testhound:testhound/remove_get_version_check

Conversation

@testhound

Copy link
Copy Markdown
Contributor

This PR removes a unnecessary CUDA toolkit version check.

@testhound
testhound requested a review from gmarkall as a code owner August 29, 2022 21:05
@testhound

Copy link
Copy Markdown
Contributor Author

gpuci run tests

@sklam sklam added 3 - Ready for Review CUDA CUDA related issue/PR labels Aug 29, 2022
@gmarkall gmarkall added this to the Numba 0.57 RC milestone Aug 30, 2022

@gmarkall gmarkall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. The code changes look good but the test numba.cuda.tests.cudapy.test_intrinsics.TestCudaIntrinsic.test_habs_ptx should also be updated.

@gmarkall gmarkall added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Sep 2, 2022
@testhound

Copy link
Copy Markdown
Contributor Author

@gmarkalltest test case habs_ptx has been updated. Thanks for the catch.

@testhound

Copy link
Copy Markdown
Contributor Author

gpuci run tests

@gmarkall gmarkall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the update!

@gmarkall gmarkall added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Sep 6, 2022
@esc

esc commented Sep 7, 2022

Copy link
Copy Markdown
Member

Thank you for the patch!

@esc
esc merged commit f793abf into numba:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge CUDA CUDA related issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants