Skip to content

Fix issue 8370 #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 16 commits into from
Jan 11, 2023
Merged

Fix issue 8370 #8376

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
72bbc5e
added unit test to reproduce issue #8370
bszollosinagy Aug 21, 2022
6f366f5
added a unit test that reproduces another suggested problem in Issue …
bszollosinagy Aug 21, 2022
bfae727
added fix of issue #8370, as suggested by gmarkall.
bszollosinagy Aug 21, 2022
2d8ac7a
added fix for ravel() in the same spirit as the fix for issue 8370
bszollosinagy Aug 21, 2022
c24796d
added test to see if the writeable flag is set after ravel() based on…
bszollosinagy Aug 22, 2022
f3f12c6
mutability of the array resulting from ravel() is determined by wheth…
bszollosinagy Aug 22, 2022
5991a55
Streamlined a boolean expression, and added documentation string to u…
bszollosinagy Aug 22, 2022
2d70048
restart CI tests
bszollosinagy Sep 3, 2022
b43a84a
Merge branch 'main' into fix_issue_8370
bszollosinagy Sep 4, 2022
d4b40c0
only set read-only, when the source is read-only and we will not do a…
bszollosinagy Sep 4, 2022
ac22f68
added clarification about why we always remove the readonly flag when…
bszollosinagy Sep 4, 2022
84df01f
Merge branch 'numba:main' into fix_issue_8370
bszollosinagy Jan 10, 2023
61fb113
rephrased the comment about how we ensure identical behaviour with NumPy
bszollosinagy Jan 10, 2023
8f64f1b
typo: NumPy
bszollosinagy Jan 10, 2023
b1fd752
* removed the name of the exception expected when the test fails, bec…
bszollosinagy Jan 10, 2023
ea8f5e8
* now uses np.testing.assert_array_equal for more detailed error repo…
bszollosinagy Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rephrased the comment about how we ensure identical behaviour with NumPy
  • Loading branch information
@bszollosinagy
bszollosinagy committed Jan 10, 2023
commit 61fb113ee1aaffd05b25c2cd12d123fd8b81fe6e
9 changes: 6 additions & 3 deletions numba/core/typing/arraydecl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,12 @@ def resolve_flatten(self, ary, args, kws):
# Only support no argument version (default order='C')
assert not kws
assert not args
# Just like in Numpy: "np.copy clears previously
# set WRITEABLE=False flag"
# Numba also sets readonly=False (b/c flatten returns a copy())
# To ensure that Numba behaves exactly like Numpy,
# we also clear the read-only flag when doing a "flatten"
# Why? Two reasons:
# Because flatten always returns a copy. (see NumPy docs for "flatten")
# And because a copy always returns a writeable array.
# ref: https://numpy.org/doc/stable/reference/generated/numpy.copy.html
return signature(ary.copy(ndim=1, layout='C', readonly=False))

def generic_resolve(self, ary, attr):
Expand Down