Repository navigation
Cleanup old support for Python 3.6 and earlier code - #8318
Closed
jamesobutler wants to merge 1 commit into
Closed
jamesobutler wants to merge 1 commit into
jamesobutler wants to merge 1 commit into
Conversation
Numba set the minimum required Python version to 3.7 in numba@7bdd800.
jamesobutler
force-pushed
the
drop-pre-python-3.7
branch
from
August 7, 2022 16:15
837273d to
7179972
Compare
Contributor
Author
|
Similar to changes made in #7920, but that PR has seemingly become stale? I did not see this existing PR because it had fallen down to the 3rd page of the open PRs. Feel free to close this as a duplicate. |
Member
|
@jamesobutler thank you for submitting this. I plan to look at this PR soon. |
Member
|
@jamesobutler thank you for submitting this. I compared this with #7920 today. I think we will need to adopt some of the diff of this PR. |
esc
added
4 - Waiting on reviewer
Member
|
@jamesobutler #7920 has been updated to include the "missing" changes from this PR. Would you have a spare moment to cross-check it? That would be most appreciated here since you've looked into this already! Thank you! 🙏 |
Member
|
@jamesobutler thank you again for your review of #7920! I will close this now as duplicate. |
esc
added
duplicate
abandoned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numba set the minimum required Python version to 3.7 in 7bdd800. This PR removes extra code that won't be executed based on this current minimum requirement of Python 3.7.
numba/numba/__init__.py
Lines 140 to 141 in aaa6a00