Repository navigation
Testhound/native cast 8138 - #8154
Merged
Merged
Conversation
Contributor
Author
|
gpuci run tests |
gmarkall
approved these changes
Jul 1, 2022
gmarkall
left a comment
gmarkall
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix - this looks good to me.
@esc / @stuartarchibald Could this have a CUDA buildfarm run please?
gmarkall
added
Pending BuildFarm
Member
|
Member
Was all green! |
esc
added
BuildFarm Passed
gmarkall
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes pythons casts on float16 types in kernels as outline in this issue:
#8138