Repository navigation
Fix NumPy capitalisation in docs. - #8144
Merged
Merged
Conversation
As title. NumPy is written as "NumPy".
stuartarchibald
added
2 - In Progress
Effort - short
stuartarchibald
marked this pull request as ready for review
June 10, 2022 14:30
esc
requested changes
Jun 16, 2022
esc
left a comment
esc
left a comment
Member
There was a problem hiding this comment.
I used git grep in the docs subdirectory and only found the following, in a source code comment:
https://github.com/numba/numba/blob/main/docs/source/user/cfunc.rst?plain=1#L175
esc
added
4 - Waiting on author
Fix up a "numpy" that was missed in the docs.
stuartarchibald
added
4 - Waiting on reviewer
Member
|
Thank you for the patch! |
Contributor
Author
Thanks, fixed in 146e72d |
esc
approved these changes
Jun 21, 2022
esc
added
5 - Ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. NumPy is written as "NumPy".