Skip to content

CUDA: Fix some missed changes from dropping 9.2 - #8142

Merged
sklam merged 1 commit into
numba:mainfrom
gmarkall:cuda-9.2-missed
Jun 9, 2022
Merged

CUDA: Fix some missed changes from dropping 9.2#8142
sklam merged 1 commit into
numba:mainfrom
gmarkall:cuda-9.2-missed

Conversation

@gmarkall

@gmarkall gmarkall commented Jun 8, 2022

Copy link
Copy Markdown
Member

When toolkit 9.2-10.1 support was dropped in #7878, a couple of bits got missed.

  • Most importantly, the Conda recipe still required only 9.2 - it should be 10.2.
  • The missing function error message stated that it required CUDA 9.2. Since all APIs we use are available in all supported toolkit versions, the error message need no longer state a CUDA requirement.
  • All supported toolkit versions implement nvvmLazyAddModuleToProgram, so we no longer need a workaround for it.

@gmarkall gmarkall added 2 - In Progress CUDA CUDA related issue/PR labels Jun 8, 2022
@gmarkall gmarkall added this to the Numba 0.56 RC milestone Jun 8, 2022
@gmarkall

gmarkall commented Jun 8, 2022

Copy link
Copy Markdown
Member Author

gpuci run tests

stuartarchibald
stuartarchibald approved these changes Jun 8, 2022
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, looks good on inspection (have also grepped for other 9.2 references and there don't appear to be any that are relevant).

@stuartarchibald stuartarchibald self-assigned this Jun 8, 2022
@stuartarchibald stuartarchibald added Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels Jun 8, 2022
@stuartarchibald

stuartarchibald commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_133.

@stuartarchibald

stuartarchibald commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_133.

Passed.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm 4 - Waiting on CI Review etc done, waiting for CI to finish labels Jun 8, 2022
@sklam
sklam merged commit 2f89d45 into numba:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@sklam sklam Awaiting requested review from sklam
@esc esc Awaiting requested review from esc

Assignees

@stuartarchibald stuartarchibald

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR

Projects

None yet

Milestone

Numba 0.56 RC

Development

Successfully merging this pull request may close these issues.

3 participants

@gmarkall @stuartarchibald @sklam