Repository navigation
Fix CUDA print tests on Windows - #8123
Merged
Merged
Conversation
This fix uses a subprocess to run the tests in rather than trying to be clever and capture the low-level streams of the current process.
It is no longer needed.
Member
Author
|
gpuci run tests |
Member
Author
|
gpuci run tests |
stuartarchibald
approved these changes
Jun 2, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch, looks good on inspection.
stuartarchibald
added
4 - Waiting on CI
Member
Author
|
@esc / @stuartarchibald Could this have a CUDA smoketest please? |
Member
|
Contributor
Thanks @esc, this passed. |
stuartarchibald
added
BuildFarm Passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the CUDA print tests on Windows (and should make them more generally robust) by running the test code in a subprocess and capturing its output, instead of trying to run in the current process with captured output.
Fixes #8005.