Skip to content

Pin meta.yaml to llvmlite 0.38 series - #8084

Merged
sklam merged 1 commit into
numba:release0.55from
sklam:misc/pin_llvmlite_0.38
May 24, 2022
Merged

Pin meta.yaml to llvmlite 0.38 series#8084
sklam merged 1 commit into
numba:release0.55from
sklam:misc/pin_llvmlite_0.38

Conversation

@sklam

@sklam sklam commented May 20, 2022

Copy link
Copy Markdown
Member

as titled

@sklam
sklam changed the base branch from main to release0.55 May 20, 2022 01:47
sklam added a commit to sklam/numba that referenced this pull request May 20, 2022
@sklam
Merge PR numba#8084
8bb21fc
This was referenced May 20, 2022
Closed
Closed
@sklam

sklam commented May 20, 2022

Copy link
Copy Markdown
Member Author

Without this, llvmlite 0.39.0dev0 can be installed with numba 0.55 causing numba.tests.test_entrypoints and numba.tests.test_typedlist.TestTypedList.test_repr_long_list_ipython to fail. Both failures are caused by llvmpy deprecation warnings.

@esc esc added this to the 0.55.2 milestone May 23, 2022
stuartarchibald
stuartarchibald reviewed May 23, 2022
View reviewed changes
Comment thread buildscripts/condarecipe.local/meta.yaml
- setuptools
# On channel https://anaconda.org/numba/
- llvmlite >=0.38.0rc1,<0.39
- llvmlite 0.38.*

@stuartarchibald stuartarchibald May 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- llvmlite 0.38.*
- llvmlite >=0.38.0,<0.39

Should it be this (in both cases) to avoid RCs and dev builds etc?

@sklam sklam May 23, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <0.39 is picking up dev builds on 0.39 though. That's the main reason to change.

@sklam sklam May 23, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.38.* would only pick up 0.38 rc and dev builds. And one will have to be quite creative to do that given the numba/label/dev channel is the only place to get them.

@stuartarchibald stuartarchibald May 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. From OOB discussion, it was elected to leave this as-is. 0.38.* should be sufficient.

@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review Effort - short Short size effort needed and removed 3 - Ready for Review labels May 23, 2022
@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels May 23, 2022
stuartarchibald
stuartarchibald approved these changes May 24, 2022
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels May 24, 2022
@sklam
sklam merged commit 1b2408b into numba:release0.55 May 24, 2022
@sklam
sklam deleted the misc/pin_llvmlite_0.38 branch May 24, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes
@gmarkall gmarkall Awaiting requested review from gmarkall
@esc esc Awaiting requested review from esc esc is a code owner

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Milestone

Numba 0.55.2

Development

Successfully merging this pull request may close these issues.

3 participants

@sklam @stuartarchibald @esc