Repository navigation
Fix erroneous array count in parallel gufunc kernel generation. - #8081
Merged
Merged
Conversation
Contributor
Author
|
Observation: The code path for ufunc and gufunc both run through the code changed in the diff, I think the +1 to the array count is only needed in the case of a ufunc. Next thing to try is branching on |
stuartarchibald
added
3 - Ready for Review
Effort - short
Contributor
Author
|
xref reproducer: #8032 (comment) |
sklam
approved these changes
Jun 7, 2022
sklam
left a comment
sklam
left a comment
Member
There was a problem hiding this comment.
Make sense, and existing code already cover testing it.
Without this patch, an extra slot would be allocated when the type signature has a "void" return (output array declared).
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.