Skip to content

update max NumPy for 0.55.2 - #8075

Merged
sklam merged 4 commits into
numba:release0.55from
esc:0.55.2/update_max_numpy
May 23, 2022
Merged

update max NumPy for 0.55.2#8075
sklam merged 4 commits into
numba:release0.55from
esc:0.55.2/update_max_numpy

Conversation

@esc

@esc esc commented May 19, 2022

Copy link
Copy Markdown
Member

As title -- companion for #8067

@esc
esc requested review from sklam and stuartarchibald as code owners May 19, 2022 11:52
This was referenced May 19, 2022
Closed
Closed
@esc esc added this to the 0.55.2 milestone May 19, 2022
stuartarchibald
stuartarchibald reviewed May 19, 2022
View reviewed changes
Comment thread numba/__init__.py Outdated
raise ImportError("Numba needs NumPy 1.18 or greater")
elif numpy_version > (1, 21):
elif numpy_version > (1, 22):
raise ImportError("Numba needs NumPy 1.21 or less")

@stuartarchibald stuartarchibald May 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message needs adjusting?

@esc esc May 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, good catch.

@esc esc May 19, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 972194f

stuartarchibald
stuartarchibald reviewed May 23, 2022
View reviewed changes

@stuartarchibald stuartarchibald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I think these also need updates:

numba/README.rst

Line 53 in 76720bf

* NumPy >=1.18,<1.22 (can build with 1.11 for ABI compatibility).

and

numba/docs/source/user/installing.rst

Lines 8 to 9 in 76720bf

Numba is compatible with Python 3.7--3.10, and Numpy versions 1.18 up
to 1.21.

and

numba/buildscripts/condarecipe.local/meta.yaml

Line 46 in 76720bf

- numpy >=1.18,<1.22

@esc

esc commented May 23, 2022

Copy link
Copy Markdown
Member Author

Thanks for the patch. I think these also need updates:

numba/README.rst

Line 53 in 76720bf

* NumPy >=1.18,<1.22 (can build with 1.11 for ABI compatibility).

and

numba/docs/source/user/installing.rst

Lines 8 to 9 in 76720bf

Numba is compatible with Python 3.7--3.10, and Numpy versions 1.18 up
to 1.21.

and

numba/buildscripts/condarecipe.local/meta.yaml

Line 46 in 76720bf

- numpy >=1.18,<1.22

done in: 3db04a8

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels May 23, 2022
@sklam
sklam merged commit 25f7f34 into numba:release0.55 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartarchibald stuartarchibald stuartarchibald left review comments
@sklam sklam sklam approved these changes

Assignees

No one assigned

Labels

5 - Ready to merge Review and testing done, is ready to merge

Projects

None yet

Milestone

Numba 0.55.2

Development

Successfully merging this pull request may close these issues.

3 participants

@esc @stuartarchibald @sklam