Skip to content

Migrate random glue_lowering to overload where easy #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 9 commits into from
Aug 17, 2022
Merged

Migrate random glue_lowering to overload where easy #8061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bea6f65
Migrate random `glue_lowering` to `overload` where easy
apmasell May 17, 2022
ba597b0
Fix missing array overrides
apmasell Jun 1, 2022
189c9ae
Relax types on hypergeometric
apmasell Jun 2, 2022
fe6fd8e
Add missing tests and remove unncessary type checks
apmasell Jul 18, 2022
4fa48fa
Fix parameter names and test `size=None`
apmasell Jul 20, 2022
c100b2f
Create special unit tests for gamma distribution over array
apmasell Jul 25, 2022
f8684a9
Ensure logseries works on 32-bit
apmasell Jul 26, 2022
74bfeae
Add test for remaining random array implementations
apmasell Jul 27, 2022
f5c5b8f
Add test for vonmises random array
apmasell Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for vonmises random array 
Include test for vonmises random array. This is another one where the CPython
algorithm is used instead of the NumPy one.
  • Loading branch information
@apmasell
apmasell committed Aug 4, 2022
commit f5c5b8f74c7ffdf8d98c7a282d5443ac9e5d0c02
1 change: 0 additions & 1 deletion numba/cpython/randomimpl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,6 @@ def _impl(n, p):
np_prod = n * p
bound = min(n, np_prod + 10.0 * math.sqrt(np_prod * q + 1))

finished = False
total = 0
while niters > 0:
X = 0
Expand Down
3 changes: 3 additions & 0 deletions numba/tests/test_random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,9 @@ def test_numpy_uniform(self):
def test_numpy_wald(self):
self._check_array_dist("wald", (0.1, 0.4))

def test_numpy_vonmises(self):
self._check_array_dist_self("vonmises", (0.5, 2.5))

def test_numpy_zipf(self):
self._check_array_dist("zipf", (2.5,))

Expand Down