Skip to content

Fix coverage checking #8057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esc merged 7 commits into from
May 18, 2022
Merged

Fix coverage checking #8057

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ae190f
Fix coverage
gmarkall May 16, 2022
32399e1
Set run_coverage.py perms to executable
gmarkall May 16, 2022
4f0091d
Add rudimentary usage and argument check
gmarkall May 16, 2022
5bbcfa1
Remove coverage script
gmarkall May 18, 2022
0f11ba0
Remove duplicate version of old coverage config file
gmarkall May 18, 2022
3f97b89
Document how to measure coverage
gmarkall May 18, 2022
07da5b8
Remove run_coverage.py from repomap
gmarkall May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix coverage
  • Loading branch information
@gmarkall
gmarkall committed May 16, 2022
commit 6ae190f84bcaecdc0e3194e448a8d6fa8954b7b3
15 changes: 15 additions & 0 deletions coverage.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# configuration file used by run_coverage.py

@sklam sklam May 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a .coveragerc

[run]
branch = True
source = numba

[report]

exclude_lines =
pragma: no cover
if __name__ == .__main__.:

omit =
*/__main__.py

[html]
18 changes: 12 additions & 6 deletions run_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,28 @@


if __name__ == "__main__":
# We disallow single-process mode, since some hacks are needed for
# multiprocess'ed coverage to work.
for arg in sys.argv:
if arg.startswith('-m') or arg.startswith('--multiprocess'):
print("Coverage can only be run single-threaded; multiprocess "
"requested. Aborting.")
sys.exit(1)

# We must start coverage before importing the package under test,
# otherwise some lines will be missed.
config_file = os.path.join(
os.path.dirname(os.path.dirname(__file__)),
'.coveragerc')
os.path.dirname(__file__),
'coverage.conf')

@sklam sklam May 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a .coveragerc (https://github.com/numba/numba/blob/main/.coveragerc)

os.environ['COVERAGE_PROCESS_START'] = config_file
cov = coverage.coverage(config_file=config_file)
cov.start()

from numba import runtests
from numba.testing import _runtests

html_dir = 'htmlcov'
try:
# NOTE: we force single-process mode, since some hacks are needed
# for multiprocess'ed coverage to work.
runtests.main(*sys.argv[1:])
_runtests.main(*sys.argv)
except SystemExit:
pass
finally:
Expand Down