Skip to content

Ensure pthread is linked in when building for ppc64le. - #8052

Merged
sklam merged 2 commits into
numba:mainfrom
sklam:misc/cxx_pthread_atfork
May 16, 2022
Merged

sklam merged 2 commits into
numba:mainfrom
sklam:misc/cxx_pthread_atfork

Conversation

@sklam

@sklam sklam commented May 13, 2022

Copy link
Copy Markdown
Member

This problem is a variation of #7302.

@sklam
sklam marked this pull request as ready for review May 16, 2022 17:07
@sklam
sklam requested review from esc and stuartarchibald as code owners May 16, 2022 17:07
@sklam

sklam commented May 16, 2022

Copy link
Copy Markdown
Member Author

tested as part of #8053 and its all green

@sklam sklam added the Effort - short Short size effort needed label May 16, 2022

@gmarkall gmarkall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just looked at the notes and discussion on #8053 and the changes here including the addition of the pycc fix make sense, and #8053 suggests that this PR helps towards stabilization.

@gmarkall gmarkall added BuildFarm Passed For PRs that have been through the buildfarm and passed 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels May 16, 2022
@sklam
sklam merged commit 4684b9c into numba:main May 16, 2022
@sklam
sklam deleted the misc/cxx_pthread_atfork branch May 16, 2022 22:19
esc pushed a commit to esc/numba that referenced this pull request May 22, 2022
esc added a commit to sklam/numba that referenced this pull request May 22, 2022
* backport/0.55.2/8052:
  Backport numba#8052 Ensure pthread is linked in when building for ppc64le.
sklam added a commit that referenced this pull request May 23, 2022
Backport #8052 Ensure pthread is linked in when building for ppc64le.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants