Repository navigation
Make Python 3.10 kwarg peephole less restrictive - #8044
Conversation
|
I did a quick check. It does resolve the failure in |
|
smoketest BFID: |
This passed on multiple build jobs with Python 3.10, and all other build jobs not impacted by some other unrelated issue. Just checked into the few failing Python 3.10 jobs, there's still a couple that are reporting the issue in #8043. Need to take a closer look as to what has happened. |
@stuartarchibald If you post the list of tests I'm happy to take a look. |
Thanks @njriasan it's these two tests, same failures as in #8043:
What I'm not sure about is if this is caused by a genuine issue with this patch or there's something unusual going on in the farm builds. Set up was Python 3.10, np 1.21, linux 64 bit system. |
|
Thanks @stuartarchibald I couldn't reproduce locally on my M1, so I'm install docker to test with a linux 64 bit system. Will update after I've tested that. |
|
@stuartarchibald I reran the whole test file manually using a ubuntu x86 docker image. I could not reproduce any failures. I'm inclined to believe this may be a build farm issue. |
|
@stuartarchibald, I think we might be mixing up the result of two builds. I'm going to combine the two PRs (#8044 and #8046) to tests. |
Thanks @sklam |
@njriasan Thanks for checking. |
|
tested as part of #8053 and its all green |
Closes #8043
Fixes a bug in peep_hole_call_function_ex_to_call_function_kw where we raised the error if we couldn't find the varargs in the basic block and no kwargs are passed. This is an inaccurate check and we should only raise an exception if we find the args have the wrong definition.
This also fixes a bug in
peep_hole_list_to_tuplewhere the definition of the final assignment wasn't properly set.