Repository navigation
Support for NumPy BitGenerators PR#5: Generator Shuffling Methods. - #8042
Conversation
|
Reminder: Make sure the masks functionality is being used correctly, if it's not, remove it within this PR: #8041 (comment) |
929fb49 to
cf9a039
Compare
|
@kc611 thank you for opening this PR, your efforts to improve Numba are appreciated. It's good to see the |
esc
left a comment
There was a problem hiding this comment.
I think, since Numbers are only being "moved around" there should not be any ulp deviation between the expected result and the received one.
|
Using the review cheklist from https://github.com/numba/numba/pull/8209/files I have checked that:
|
esc
left a comment
There was a problem hiding this comment.
I think that public CI is currently broken, probably due to a typo. I think the following suggestion should remedy this.
Co-authored-by: esc <esc@users.noreply.github.com>
…umba into np_gen_shuffling_methods
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Testing at |
This was all green. |
This PR builds on top of #8041
Currently has the following
Generatormethods:Generator().shuffle()Generator().permutation()