Repository navigation
Support for Numpy BitGenerators PR#3: Advanced Distributions Support. - #8040
Merged
Merged
Conversation
kc611
marked this pull request as draft
May 11, 2022 19:24
kc611
changed the title
This was referenced May 12, 2022
kc611
force-pushed
the
np_adv_distributions
branch
3 times, most recently
from
June 28, 2022 12:31
efee6af to
3091085
Compare
esc
requested changes
Jun 30, 2022
esc
left a comment
esc
left a comment
Member
There was a problem hiding this comment.
The docs will need an update to reflect the new distributions.
| * :func:`numpy.random.Generator().standard_normal()` | ||
| * :func:`numpy.random.Generator().standard_exponential()` | ||
| * :func:`numpy.random.Generator().standard_gamma()` (*) | ||
| * :func:`numpy.random.Generator().uniform()` (*) |
Member
There was a problem hiding this comment.
This will need adding the distributions introduced in this PR.
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
kc611
force-pushed
the
np_adv_distributions
branch
from
July 5, 2022 07:01
6897181 to
280a920
Compare
esc
added
3 - Ready for Review
Effort - short
kc611
marked this pull request as ready for review
July 7, 2022 09:12
kc611
force-pushed
the
np_adv_distributions
branch
from
July 7, 2022 11:00
e920b91 to
8bfda92
Compare
kc611
force-pushed
the
np_adv_distributions
branch
from
July 7, 2022 11:34
2b9fd74 to
26406df
Compare
kc611
force-pushed
the
np_adv_distributions
branch
from
July 7, 2022 12:32
26406df to
30ee3a0
Compare
Member
|
|
esc
added
5 - Ready to merge
esc
approved these changes
Jul 8, 2022
esc
left a comment
esc
left a comment
Member
There was a problem hiding this comment.
I cross checked all the implemented distributions, all of them are being tested and all type-checks are implemented. Public CI and the Anaconda Build Farm have passed on this, so I am marking it as RTM now.
Member
|
Thank you for the patch! |
This was referenced Aug 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #8038
Adds the following distributions as
Generatormethods:Generator().beta()Generator().f()Generator().chisquare()Generator().standard_cauchy()Generator().pareto()Generator().weibull()Generator().power()Generator().laplace()Generator().logistic()Generator().lognormal()Generator().rayleigh()Generator().standard_t()Generator().wald()Generator().geometric()Generator().zipf()Generator().triangular()Generator().poisson()Generator().negative_binomial()