Repository navigation
CUDA fixes for Windows - #8004
Merged
Merged
Conversation
The filename may not be present on Windows, and it's not clear that checking the filename adds anything, given that there is only a single line of code in the try block with a fixed filename. When the filename is empty, no exception is raised by disassemble_cubin(), and it then attempts to access cp, which has not been set. To avoid this issue, we now unconditionally raise the RuntimeError that indicates that nvdisasm is not present.
IPC is unsupported on Windows - the fact that it worked for some driver releases in some cases was an accident.
This mostly reverts commit 7ffa4cf.
gmarkall
added
2 - In Progress
CUDA
Member
Author
|
gpuci run tests |
stuartarchibald
approved these changes
Apr 27, 2022
stuartarchibald
left a comment
stuartarchibald
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch.
stuartarchibald
added
4 - Waiting on CI
Contributor
|
Buildfarm ID: |
stuartarchibald
added
BuildFarm Passed
Contributor
Passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues on Windows:
nvdisasmis not found, theFileNotFoundError's filename is blank. There doesn't appear to be any value in checking fornvdisasmin the name, and when it's not found it resulted in incorrect logic, so I just removed the check for the filename.One issue is still outstanding on Windows with recent drivers (tests of printing functionality, #8005), which will be fixed in a separate PR.