Skip to content

Remove @overload_glue for NumPy allocators. #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 3 commits into from
Jun 22, 2022
Merged

Remove @overload_glue for NumPy allocators. #7999

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb25184
Remove `@overload_glue` for NumPy allocators.
stuartarchibald Mar 29, 2022
0401550
Move array '.imag' and '.real' to overloads, fix up.
stuartarchibald Apr 21, 2022
d69a6ac
Make readonly array through typing only.
stuartarchibald Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make readonly array through typing only. 
As title.
  • Loading branch information
@stuartarchibald
stuartarchibald committed Jun 22, 2022
commit d69a6acd3c2c584d68ad86a59c5ba756fca38ed9
7 changes: 2 additions & 5 deletions numba/np/arrayobj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2589,16 +2589,13 @@ def impl(arr):

@intrinsic
def _force_readonly(tyctx, arr):

@stuartarchibald stuartarchibald Apr 26, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to numba.np.unsafe.ndarray?

"""Takes an array, and returns it with the readonly bit set in both typing
and lowering."""
"""Takes an array, and returns it with the readonly bit set through
typing"""
sig = arr.copy(readonly=True)(arr)

def impl(cgctx, builder, sig, llargs):
arrayty = make_array(arr)
array = arrayty(cgctx, builder, llargs[0])
# make readonly hack
parent = array._datamodel.get_type('parent')
setattr(array, 'parent', Constant(cgctx.get_value_type(parent), None))
return impl_ret_borrowed(cgctx, builder, sig.return_type,
array._getvalue())
return sig, impl
Expand Down