Repository navigation
added sys import - #7911
Merged
Merged
added sys import#7911
Conversation
Contributor
|
In the original file on lines 325 and 326 is the only place where "sys" is used. Those are really debugging code that should be removed so my preferred solution is to remove those rather than adding a sys import. Can you make that change please? |
DrTodd13
requested changes
Mar 15, 2022
DrTodd13
left a comment
DrTodd13
left a comment
Contributor
There was a problem hiding this comment.
See my comment about removing the line that uses sys.
Contributor
Author
|
Ooh sorry my bad i misunderstood . |
DrTodd13
requested changes
Mar 15, 2022
| exp_name_to_tuple_var) | ||
| if config.DEBUG_ARRAY_OPT: | ||
| sys.stdout.flush() | ||
|
|
Contributor
There was a problem hiding this comment.
Should only be one blank line here.
Contributor
|
Thanks for making this change. Just that one additional picky thing about the extra line and I think we're done. |
Contributor
|
Thanks for the patch @Nightfurex, thanks for reviewing @DrTodd13. |
stuartarchibald
added
the
5 - Ready to merge
stuartarchibald
approved these changes
Mar 15, 2022
Contributor
|
Note: I've manually tested against the reproducer in #7910. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.