Skip to content

Ensure np.argmin/no.argmax return type is intp - #7855

Merged
sklam merged 1 commit into
numba:mainfrom
stuartarchibald:fix/7853
Feb 24, 2022
Merged

sklam merged 1 commit into
numba:mainfrom
stuartarchibald:fix/7853

Conversation

@stuartarchibald

Copy link
Copy Markdown
Contributor

As title. Includes test cases.

Fixes #7853

As title. Includes test cases.

Fixes numba#7853

@sklam sklam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also confirmed that the reproducer in #7853 works correctly with this patch.

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Feb 22, 2022
@stuartarchibald stuartarchibald added this to the Numba 0.56 RC milestone Feb 22, 2022
@sklam
sklam merged commit 1f9847c into numba:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numpy.argmin(arr, axis=int64), where (arr.ndim > 1), returns passes through the dtype of arr

2 participants