Skip to content

min() and max() support for np.datetime and np.timedelta #7836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklam merged 13 commits into from
May 26, 2022
Merged

min() and max() support for np.datetime and np.timedelta #7836

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a305435
Added tests
benwilliamgraham Feb 11, 2022
9def383
Added more tests
benwilliamgraham Feb 11, 2022
75c23bc
Fixed array max/min
benwilliamgraham Feb 15, 2022
42ee62e
Fixed return/continue
benwilliamgraham Feb 15, 2022
c973f46
Fixed min/max reduction
benwilliamgraham Feb 16, 2022
8a7e68c
Added reductions
benwilliamgraham Feb 17, 2022
45e82c4
Reorg
benwilliamgraham Feb 18, 2022
b7d3048
Update numba/core/typing/npdatetime.py
benwilliamgraham Feb 18, 2022
dd32396
Update numba/np/npdatetime.py
benwilliamgraham Feb 18, 2022
07276e0
Fixed max
benwilliamgraham Feb 18, 2022
7b0e387
Removed unenesary typing
benwilliamgraham Feb 23, 2022
ba99506
Adressed comments
benwilliamgraham May 18, 2022
4017346
Update numba/core/typing/builtins.py
benwilliamgraham May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update numba/core/typing/builtins.py 
Co-authored-by: Siu Kwan Lam <1929845+sklam@users.noreply.github.com>
  • Loading branch information
@benwilliamgraham @sklam
benwilliamgraham and sklam authored May 24, 2022
commit 4017346adb52ab92dd350ee0660e863f74d35292
1 change: 0 additions & 1 deletion numba/core/typing/builtins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,6 @@ def generic(self, args, kws):
assert len(args) == 1
if isinstance(args[0], (types.DType, types.NumberClass)):
return signature(args[0].dtype, *args)
assert None


#------------------------------------------------------------------------------
Expand Down