Repository navigation
add sdist command and umask reminder - #7801
Conversation
| * [ ] Build and upload conda packages on buildfarm (check "upload"). | ||
| * [ ] Build wheels (`$PYTHON_VERSIONS`) on the buildfarm. | ||
| * [ ] Verify packages uploaded to Anaconda Cloud and move to `numba/label/main`. | ||
| * [ ] Build sdist locally using `python setup.py sdist --user=ci --group=numba` with umask `0022`. |
There was a problem hiding this comment.
Did the umask used get confirmed by @seibert ? xref: #7800 (comment)
There was a problem hiding this comment.
Thanks for confirming.
|
Note: I think merge of this could reasonably close #7800. |
stuartarchibald
added
4 - Waiting on author
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch. Suggest minor change to match output of python setup.py sdist --help which gives:
--owner (-u) Owner name used when creating a tar file [default:
current user]
| * [ ] Build and upload conda packages on buildfarm (check "upload"). | ||
| * [ ] Build wheels (`$PYTHON_VERSIONS`) on the buildfarm. | ||
| * [ ] Verify packages uploaded to Anaconda Cloud and move to `numba/label/main`. | ||
| * [ ] Build sdist locally using `python setup.py sdist --user=ci --group=numba` with umask `0022`. |
There was a problem hiding this comment.
| * [ ] Build sdist locally using `python setup.py sdist --user=ci --group=numba` with umask `0022`. | |
| * [ ] Build sdist locally using `python setup.py sdist -u=ci --group=numba` with umask `0022`. |
There was a problem hiding this comment.
should we then also use -g for coherence?
There was a problem hiding this comment.
Am happy with either, though think that -g does make it more consistent. The most important thing is to fix the --user part as it seems like that doesn't exist!
There was a problem hiding this comment.
ok, what about using --owner which is the long-form of -u ? That would make it somewhat more obvious what the options do?
There was a problem hiding this comment.
--owner sounds good RE obviousness!
| * [ ] Verify packages uploaded to Anaconda Cloud and move to | ||
| `numba/label/main`. | ||
| * [ ] Build wheels (`$PYTHON_VERSIONS`) on the buildfarm. | ||
| * [ ] Build sdist locally using `python setup.py sdist --user=ci --group=numba` with umask `0022`. |
There was a problem hiding this comment.
| * [ ] Build sdist locally using `python setup.py sdist --user=ci --group=numba` with umask `0022`. | |
| * [ ] Build sdist locally using `python setup.py sdist -u=ci --group=numba` with umask `0022`. |
There was a problem hiding this comment.
should we then also use -g for coherence?
As title
|
I have modified the patch to include |
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
5 - Ready to merge
4 participants
As title